search

pulp / plugin_template

GNU General Public License v2.0
8 stars 35 forks source link

Install packages from vault.centos.org on the old centos image #873

Closed lubosmj closed 3 months ago

lubosmj commented 3 months ago

[noissue]

lubosmj commented 3 months ago

This helps to resolve issues we have in the pulp-container's CI where we try installing additional packages, like flatpak, to the old centos image.

https://github.com/pulp/pulp_container/blob/d5316daf7d001a147cbb680939307a38506dfd1a/.github/workflows/scripts/post_before_script.sh#L3

lubosmj commented 3 months ago

This is more or less the continuation of https://github.com/pulp/plugin_template/commit/2237db82e4316ded4da29f4217626502ac807196 where we camouflaged the Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist message.

lubosmj commented 3 months ago

Currently being tested by https://github.com/pulp/pulp_container/pull/1653.

decko commented 3 months ago

What's gonna happen with the images that already had this change? Throw an error? Nothing?

lubosmj commented 3 months ago

What's gonna happen with the images that already had this change? Throw an error? Nothing?

Which change do you have in mind? No image in the CI should have this change and it is more about hacking the way out of the problem.

decko commented 3 months ago

What's gonna happen with the images that already had this change? Throw an error? Nothing?

Which change do you have in mind? No image in the CI should have this change and it is more about hacking the way out of the problem.

@mikedep333 submitted changes similar to this one to each supported branch. Like this https://github.com/pulp/pulp-oci-images/pull/638/files

lubosmj commented 3 months ago

Ah! I have not seen it. How about we merge that instead? 🤔