search

pulp / pulp-cli-deb

2 stars 11 forks source link

Fix '--signing-service' option not allowing HREF #39

Open tjmullicani opened 1 year ago

tjmullicani commented 1 year ago

fixes #38

quba42 commented 1 year ago

@hstct If you can find the time to test this locally, I am fine with merging it as is.

quba42 commented 1 year ago

Now that the tests in main branch have been fixed, this should be rebased on top of latest main branch, squished into a single commit.

Normally I would also say we should add a test for the new option, but given we do not yet have any test involving signing service creation, I think this would be a bit much to ask. Instead, I have opened a new issue: #46

mdellweg commented 1 year ago

More disturbing is the question why the ci workflows did not run.

mdellweg commented 1 year ago

https://github.com/pulp/pulp-cli/blob/main/pulp-glue/pulp_glue/core/context.py#L341 I don't see that PulpSigningServiceContext ever had an HREF_PATTERN.

tjmullicani commented 1 year ago

https://github.com/pulp/pulp-cli/blob/main/pulp-glue/pulp_glue/core/context.py#L341 I don't see that PulpSigningServiceContext ever had an HREF_PATTERN.

@mdellweg @quba42 I originally added it as part of https://github.com/pulp/pulp-cli/pull/560/files (before glue library was split out)

tjmullicani commented 1 year ago

Created a new pull request for pulp-cli https://github.com/pulp/pulp-cli/pull/652

quba42 commented 1 year ago

@tjmullicani Ok, I can have another go at testing this using both PR's. Not sure if I will find the time today, though.