Pin schema due to breakage in 0.7.6.

pulp / pulp-cli

https://docs.pulpproject.org/pulp_cli/

GNU General Public License v2.0

33 stars 41 forks source link

Pin schema due to breakage in 0.7.6. #935

Closed ggainey closed 3 months ago

ggainey commented 3 months ago

Example:

~ $ pip install schema
...
Successfully installed contextlib2-21.6.0 schema-0.7.6 ~ $ python3
>>> import schema as s
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'schema'
>>>

[noissue]

Review Checklist:

[ ] An issue is properly linked. [feature and bugfix only]
[ ] Tests are present or not feasible.
[ ] Commits are split in a logical way (not historically).

ggainey commented 3 months ago

may just close this, schema yanked 0.7.6

ggainey commented 3 months ago

schema yanked their broken version and we seem to be fine (for now) - closing this PR

mdellweg commented 3 months ago

Actually, instead of pinning, I would have preferred to opt the broken version out (like ...,!=0.7.6).

ggainey commented 3 months ago

At the time, I couldn't predict the maintainer's future stance, and our PR/CI?Release processes were all blocked. The pin was an immediate bandaid :) Fortunately, the maintainer responded quickly