search

pulp / pulp-cli

https://docs.pulpproject.org/pulp_cli/
GNU General Public License v2.0
33 stars 41 forks source link

Add `--repository` option to Advisory upload #936

Open pedro-psb opened 3 months ago

pedro-psb commented 3 months ago

Summary

Currently, only Packages support the --repository option on the pulp rpm content -t CONTENT_TYPE upload command.

Examples

I'd like to use:

pulp rpm content -t advisory upload --repository REPONAME --file filename.json
mdellweg commented 3 months ago

Can you comment with the appropriate version guards on pulp_rpm?

pedro-psb commented 3 months ago

Looks like this advisory upload endpoint was introduced in 3.0.0. https://github.com/pulp/pulp_rpm/commit/ab748dfd620d09c3a46559257c73225e42a4e6e3

mdellweg commented 3 months ago

The question is, when was the repository option added. And that may just well be a change in Pulpcore. Having a hard time finding it myself... Has it been available for all eternity?

pedro-psb commented 3 months ago

The ancestor class that provides repository is NoArtifactContentSerializer, from pulpcore. Looks like it was introduced here in pulpcore==3.29.0.

mdellweg commented 3 months ago

The ancestor class that provides repository is NoArtifactContentSerializer, from pulpcore. Looks like it was introduced here in pulpcore==3.29.0.

I think that's it, right! Thanks for digging it up.