search

pulp / pulp-oci-images

Containerfiles and other assets for building Pulp 3 OCI images
https://docs.pulpproject.org/pulp_oci_images/
30 stars 55 forks source link

Added missing 'pinentry' package #643

Closed COM8 closed 2 weeks ago

COM8 commented 2 months ago

This package is required to import GPG keys via e.g. gpg --import /var/lib/pulp/gpg/ppos_rpm_private.gpg inside the image.

Else it will fail with the following error:

pulp bash -c 'gpg --import /var/lib/pulp/gpg/ppos_rpm_private.gpg'
gpg: key D6763692AE005CBF: "..." not changed
gpg: key D6763692AE005CBF/D6763692AE005CBF: error sending to agent: No pinentry
gpg: error reading '/var/lib/pulp/gpg/ppos_rpm_private.gpg': No pinentry
gpg: import from '/var/lib/pulp/gpg/ppos_rpm_private.gpg' failed: No pinentry
gpg: Total number processed: 0
gpg:              unchanged: 1
gpg:       secret keys read: 1
mdellweg commented 2 months ago

I don't think this is a good addition to the container. If you need it for that command, you can install it there. But i suspect, a key with a password will not work nicely for any sort of automated package/release signing in pulp.

COM8 commented 2 months ago

I see your point there. But in my eyes an officially maintained package with a size of 256.13 KB and no real dependencies that helps handling encrypted keys is a good addition.

As far as I understand it, after importing the password encrypted GPG key to my pulp container I can remove/cache the password for signing.

stale[bot] commented 1 month ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

stale[bot] commented 2 weeks ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.