pulp / pulp-openapi-generator

GNU General Public License v2.0
4 stars 24 forks source link

Remove git_push.sh from the Ruby bindings #70

Closed ekohl closed 2 years ago

ekohl commented 2 years ago

The Ruby bindings contain a useless git_push.sh script.

$ gem unpack pulp_ansible_client-0.14.0.gem
Unpacked gem: '/tmp/pulp/pulp_ansible_client-0.14.0'
$ ls pulp_ansible_client-0.14.0/git_push.sh
pulp_ansible_client-0.14.0/git_push.sh

This then also ends up in the resulting RPM (unless we explicitly exclude it):

$ rpm -ql rubygem-pulp_ansible_client-0.13.2-1.el8.noarch.rpm | grep git_push.sh
/usr/share/gems/gems/pulp_ansible_client-0.13.2/git_push.sh

The openapi-generator wiki describes a process to skip these files using an ignore file in the output directory. The output directory differs per plugin so including them statically in the repository would require enumerating all different plugins. Instead it is written during generation. The generated file is ignored by git.

I haven't tested this PR since I don't have a test environment. For now I've focused just on Ruby because that's what I consume, but perhaps this also applies to other language bindings. I'd appreciate some guidance from maintainers on this.

fao89 commented 2 years ago

I tested and it didn't work image I'm doing other tests to see what is needed to make it work

ekohl commented 2 years ago

The test failure looks unrelated to my PR.

ekohl commented 2 years ago

Now it's green :)