Raise Faraday compatibility to < 2.0

pulp / pulp-openapi-generator

GNU General Public License v2.0

4 stars 24 forks source link

Raise Faraday compatibility to < 2.0 #77

Closed ekohl closed 2 years ago

ekohl commented 2 years ago

I'd still need to verify this works. https://github.com/OpenAPITools/openapi-generator/pull/13127 is the upstream version of replacing Faraday::UploadIO.

ekohl commented 2 years ago

I've tried to hit this code path, but I'm not sure I can. What I did:

Manually patched the gems
Raised the gemspecs
Ensured Faraday was at a new enough version (1.10.1)
Created an RPM repo
Manually uploaded an RPM into it

That was published, but it didn't hit this specific line I think. However, the application starts up without (Faraday) warnings so I think this is good to go. I'll fix the [noissue] part.