search

pulp / pulp-operator

Kubernetes Operator for Pulp 3. Under active development.
https://docs.pulpproject.org/pulp_operator/
GNU General Public License v2.0
66 stars 48 forks source link

[BUG?] Redis image support IPv6 #788

Open git-hyagi opened 1 year ago

git-hyagi commented 1 year ago

Describe the bug We are setting an IPv4 address for Redis liveness and readiness probes: https://github.com/pulp/pulp-operator/blob/05bc5969c84b9040658acfcc4159a79602116488/controllers/repo_manager/redis.go#L286 https://github.com/pulp/pulp-operator/blob/05bc5969c84b9040658acfcc4159a79602116488/controllers/repo_manager/redis.go#L307

We should validate if this could have issues in environments with only IPv6 enabled. We would also need to check if the image supports IPv6.

To Reproduce I didn't reproduce this error, this issue needs more investigation.

fao89 commented 1 year ago

it seems redis-cli -h 127.0.0.1 does some magic and works even for IPv6, but the redis itself doesn't seem to be good with IPv6 https://github.com/redis/redis/issues/3076 https://github.com/redis/redis/issues/2511#issuecomment-119666092