search

pulp / pulp-smash

A GPL-licensed Python library that facilitates integration testing of Pulp.
https://pulp-smash.readthedocs.io/
GNU General Public License v3.0
3 stars 44 forks source link

Adds nightly pytest marker #1273

Closed bmbouter closed 2 years ago

bmbouter commented 2 years ago

[noissue]

bmbouter commented 2 years ago

This LGTM, but I have a pytest question,

when running pytest not nightly, wouldn't it run parallel tests? or not parallel would run nightly tests?

I've been asking myself similar questions. Here's my current thinking at least. The nightly test run will run "all tests" like it does now. All non-nightly test runs will disinclude the nightly tagged tests by specifying -m "not nightly". I'm putting this into a plugin_template PR right now actually, I'd like to know what you think is best.

bmbouter commented 2 years ago

@fao89 wdyt about https://github.com/pulp/plugin_template/pull/567

fao89 commented 2 years ago

This LGTM, but I have a pytest question, when running pytest not nightly, wouldn't it run parallel tests? or not parallel would run nightly tests?

I've been asking myself similar questions. Here's my current thinking at least. The nightly test run will run "all tests" like it does now. All non-nightly test runs will disinclude the nightly tagged tests by specifying -m "not nightly". I'm putting this into a plugin_template PR right now actually, I'd like to know what you think is best.

I don't have an opinion on that, I'm just afraid of collision of pytest markers, I believe -m "not nightly"will trigger parallel tests, but I'm not sure if this will happen