pulp / pulp-smash

A GPL-licensed Python library that facilitates integration testing of Pulp.
https://pulp-smash.readthedocs.io/
GNU General Public License v3.0
3 stars 44 forks source link

Facilitate copying files between a host and running container #1295

Closed lubosmj closed 2 years ago

lubosmj commented 2 years ago

All commands are run as sudo docker exec or podman exec: https://github.com/pulp/pulp-smash/blob/7defa70d399cfd3d6fe99d71737ad73418a8e4cb/pulp_smash/cli.py#L319

We should implement utilities for copying content between a host and container. It is useful when dealing with temporary directories/files that were created on the fly and should be present on the Pulp's instance too (e.g., GnuPG home directories). It will eventually allow us to test features used by administrators (where direct access to Pulp is needed).

https://docs.docker.com/engine/reference/commandline/cp/

https://docs.podman.io/en/latest/markdown/podman-cp.1.html

lubosmj commented 2 years ago

This can now be closed because we are running functional tests from within a container. Copying files between the host and container is no longer needed. Temporary directories (e.g., GnuPG home directories) created in the functional tests' user space are accessible by all parties: https://github.com/pulp/pulp_container/pull/735/files#diff-6d1431d4ae17b8ee6c68c9e26883fe1fe84425cbc7f92c15a9e4683fc0c174aaR152-R221.