pulp / pulp_container

Pulp Container Registry
https://docs.pulpproject.org/pulp_container/
GNU General Public License v2.0
23 stars 44 forks source link

As a user, there is a limit to the size of content that is accepted to be retrieved via live api #532

Open goosemania opened 2 years ago

goosemania commented 2 years ago

Podman client seems to have I/O limits for different content types, e.g. signatures. It might make sense to have similar things implemented in Pulp, e.g. to protect pulp2pulp sync case when the number of signatures on the main pulp grows significantly. Usually that many signatures are not needed and is a sign that there are some old ones which are no longer needed. Allowing it to grow indefinitely may affect pulp2pulp sync performance.

lubosmj commented 4 months ago

There is a chance that clients can flood and freeze our API with a huge monolithic upload. We may want to introduce sane thresholds for uploads. The I/O limits referenced by @goosemania are defined at https://github.com/containers/image/blob/8d792a4a930c36ae3228061531cca0958ba4fe0a/internal/iolimits/iolimits.go#L4.