pulp / pulp_container

Pulp Container Registry
https://docs.pulpproject.org/pulp_container/
GNU General Public License v2.0
23 stars 44 forks source link

Allow foreign layer upload #598

Closed ipanova closed 2 years ago

ipanova commented 2 years ago

Version Please provide the versions of the pulpcore and pulp_container packages in use, and how they are installed. If you are using Pulp via Katello, please provide the Katello version.

Describe the bug docker client can be configured to send foreign layers to the registry. by default the client just skips them. not sure how podman behaves but it seems like it sends blobs to the registry regardless of the mime type. Also i've learned that currently with podman build there is no option how to create non-distributable artifacts. Also windows containers are not supported by podman

Adjust our registry logic, so it allows upload of foreign layers, but does not require it. It should however verify manifest so it contains URLs field and if not reject such manifest.

docker client when pulling prefers registry storage, over URL, podman however always looks into URL if provided and never contacts the registry.

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here. Please provide links to any previous discussions via Discourse or Bugzilla.

ipanova commented 2 years ago

https://github.com/pulp/pulp_container/pull/599