search

pulp / pulp_deb

Debian repository plugin for Pulp (pulpproject.org)
GNU General Public License v2.0
61 stars 76 forks source link

Suppress the warnings about python3-apt not being installed #1020

Closed quba42 closed 4 months ago

quba42 commented 4 months ago

closes #1019

We no longer want to see warnings like the following in the log:

pulpcore-worker: /usr/lib/python3.9/site-packages/debian/deb822.py:716: UserWarning: Parsing of Deb822 data with python3-apt’s apt_pkg was requested but this package is not importable. Is python3-apt installed?

hstct commented 4 months ago

That's great because the message was annoying

patchback[bot] commented 4 months ago

Backport to 3.0: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 98d826674f203317e615c3568ff67f2ceb82c6c4 on top of patchback/backports/3.0/98d826674f203317e615c3568ff67f2ceb82c6c4/pr-1020

Backporting merged PR #1020 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/pulp/pulp_deb.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/3.0/98d826674f203317e615c3568ff67f2ceb82c6c4/pr-1020 upstream/3.0
  4. Now, cherry-pick PR #1020 contents into that branch: 
    $ git cherry-pick -x 98d826674f203317e615c3568ff67f2ceb82c6c4

    If it'll yell at you with something like fatal: Commit 98d826674f203317e615c3568ff67f2ceb82c6c4 is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x 98d826674f203317e615c3568ff67f2ceb82c6c4
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #1020 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/3.0/98d826674f203317e615c3568ff67f2ceb82c6c4/pr-1020
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] commented 4 months ago

Backport to 3.1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.1/98d826674f203317e615c3568ff67f2ceb82c6c4/pr-1020

Backported as https://github.com/pulp/pulp_deb/pull/1022

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.