search

pulp / pulp_python

A Pulp plugin to support Python packages
GNU General Public License v2.0
35 stars 74 forks source link

Fix upload not supporting package metadata 2.3 #690

Closed gerrod3 closed 3 weeks ago

gerrod3 commented 3 weeks ago

fixes: #682

@dralley This should be safe to backport. And I'll complete full 2.3 support with #689 as a new feature for a future release.

gerrod3 commented 3 weeks ago

My thought was that it might be best to fully support metadata 2.3 before removing the path that errors out - that way there's no possibility of losing metadata.

I don't plan on releasing the next version without full 2.3 support. But if someone is encountering this error on an older supported version, I don't want them to be without a remedy until the next version comes out.

dralley commented 3 weeks ago

Strictly speaking the user isn't without remedy at the moment, they repacked the package. Not convenient though, I agree.

If it won't require much effort to add support though though (I think it won't, working on it currently), in my opinion would be better to just do a quick major release including only 2.3 support and little else.

gerrod3 commented 3 weeks ago

We can go that way as well. I'll leave this PR as is for now, and keep a lookout on your PR.

Derioss commented 3 weeks ago

thank's for your's velocity.

dralley commented 3 weeks ago

I'm going to go ahead and merge this, then rebase on top, just to simplify things.