pulp / pulp_python

A Pulp plugin to support Python packages
GNU General Public License v2.0
37 stars 76 forks source link

Fix package_types filter breaking others #692

Closed gerrod3 closed 3 months ago

gerrod3 commented 3 months ago

fixes: #691

gerrod3 commented 3 months ago

It looks like complete magic to me, how this config is used, but the change is fine.

Not related to this change, but is BandersnatchConfig.config a class variable?

BandersnatchConfig is a singleton object and the config variable is the parsed config options, it is initialized during init, but it is not a class variable.

patchback[bot] commented 3 months ago

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/a37d040b901d70a527c208fab9edef486039a205/pr-692

Backported as https://github.com/pulp/pulp_python/pull/693

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] commented 3 months ago

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/a37d040b901d70a527c208fab9edef486039a205/pr-692

Backported as https://github.com/pulp/pulp_python/pull/694

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.