search

pulp / pulpcore

Pulp 3 pulpcore package https://pypi.org/project/pulpcore/
GNU General Public License v2.0
301 stars 116 forks source link

Require each pulpcore feature or bugfix to come with a functional test #1930

Open pulpbot opened 2 years ago

pulpbot commented 2 years ago

Author: @bmbouter (bmbouter)

Redmine Issue: 7436, https://pulp.plan.io/issues/7436

Background

It would be great if each fix or feature came with a test asserting that fix/feature is working with the same commit as the fix or feature. This was originally proposed on pulp-dev here

Todo

  1. Revise the Functional Tests section here to indicate a functional test is a requirement: https://docs.pulpproject.org/pulpcore/contributing/tests.html#functional-tests
  2. Include writing a test in the workflow here: https://docs.pulpproject.org/pulpcore/contributing/index.html#workflow
  3. Revise this page to be clearer about the functional test requirement: https://docs.pulpproject.org/pulpcore/contributing/pull-request-walkthrough.html#checklist
pulpbot commented 2 years ago

From: @bmbouter (bmbouter) Date: 2021-03-30T17:57:01Z

I am not currently working on this, so I am un-assigning.

stale[bot] commented 2 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!