Open lubosmj opened 1 day ago
We are also planning to remove OTEL_PREFIX
and PULP_OTEL_ENABLED
from our container image:
We will remove OTEL_PREFIX
entirely as we will no longer use it. The PULP_OTEL_ENABLED
env var will be moved to be proper settings in pulp as an application and it will be called OTEL_ENABLED
.
Recently, we discovered that vendoring a customized version of our instrumentation middleware offers significant advantages, primarily due to the added flexibility it provides for managing metric attributes. Upstream instrumentation libraries lack options for hooking into metrics to modify their behavior. These metrics often include attributes that do not apply to standard use cases. Additionally, contributing upstream seems to be a bit challenging, as spans and metrics are tightly coupled in their implementation.
The goal of this task is to:
We already have a working concept in the pulp-service repository: content-app: https://github.com/pulp/pulp-service/blob/4a72206d961b0d3e751405850b27bdc366414682/pulp_service/pulp_service/app/content.py#L69 api-app: https://github.com/pulp/pulp-service/blob/4a72206d961b0d3e751405850b27bdc366414682/pulp_service/pulp_service/app/middleware.py#L74