search

pulp / squeezer

Ansible modules to control a pulp3 server
GNU General Public License v3.0
24 stars 35 forks source link

Add retain_package_versions to rpm_repository.py #154

Closed chtaylo2 closed 7 months ago

chtaylo2 commented 7 months ago

Hi, Can we add "retain_package_versions" INTEGER as an optional key:pair for RPM Repository?

https://github.com/pulp/squeezer/blob/develop/plugins/modules/rpm_repository.py#L105 https://github.com/pulp/squeezer/blob/develop/plugins/modules/rpm_repository.py#L110

I would create a PR but i'm not sure what your requirements are for contributing.

Thank you

mdellweg commented 7 months ago

Oh, please go ahead. Mostly, I'd want to see a test for it (specifically so, since the module is still on the old codebase about to be rewritten for pulp_glue, and refactoring can only guarantee things covered by tests). Please consult the docs for writing and recording tests. You should add yourself to the authors too. And lastly (obviously) we need to get the CI green, so please stay around for that.

chtaylo2 commented 7 months ago

@mdellweg - Thank you for the feedback. I've created the PR as planned. https://github.com/pulp/squeezer/pull/155

tests are included and passing 100%

chtaylo2 commented 7 months ago

Closing issue. Thank you

mdellweg commented 6 months ago

Thank you!