pulquero / BatteryAggregator

MIT License
34 stars 7 forks source link

Agregator logs zero until first battery comes online. #67

Closed rldoose closed 2 months ago

rldoose commented 2 months ago

Please include system details: Three JBD serial batteries

Hardware: Cerbo/RPi??? I have run it on both Cerbo and RPi with same results

Setup: DVCC? NA

Please provide output from dbus-spy. NA

Please attach any relevant logs. Log location is /var/log/BatteryAggregator/current. NA

The zero volts is annoying, and just plain wrong. Agregator should not report until there is something to report. This wacks the scale of my graphs which must now go from zero to 14.2 instead of about 12 to 14.2.

Screenshot 2024-08-24 at 21 00 09 Screenshot 2024-08-24 at 20 59 40
pulquero commented 2 months ago

Wow, "just plain wrong", harsh. The only thing that is plain wrong is that statement. The aggregator is a battery, a battery not reporting a voltage can cause issues. What I can do is probably delay dbus registration until a valid voltage is available.

rldoose commented 2 months ago

You are right, I was unnecessarily harsh. Especially directed at someone providing something for free, Please accept my apologies.

On Aug 25, 2024, at 09:18, pulquero @.***> wrote:

Wow, "just plain wrong", harsh. The only thing that is plain wrong is that statement. The aggregator is a battery, a battery not reporting a voltage can cause issues. What I can do is probably delay dbus registration until a valid voltage is available.

— Reply to this email directly, view it on GitHub https://github.com/pulquero/BatteryAggregator/issues/67#issuecomment-2308834755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBAH46NENZJGPFPPD22D5DZTHKTPAVCNFSM6AAAAABNCBQFG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHAZTINZVGU. You are receiving this because you authored the thread.