Open martinglass opened 3 years ago
I already have provisions for such a flag, but the tricky bit is setting defaults only when used for the first time. Please include lifetime values that work for you (best obtained when running auto-calibration for a few rounds) so I have a bigger sample from which to determine default values.
Thanks. Will do 👍
From: pulquero @.> Sent: 20 July 2021 11:07 To: pulquero/RotorHazard @.> Cc: martinglass @.>; Author @.> Subject: Re: [pulquero/RotorHazard] Easy Defaults for PH (#46)
I already have provisions for such a flag, but the tricky bit is setting defaults only when used for the first time. Please include lifetime values that work for you (best obtained when running auto-calibration for a few rounds) so I have a bigger sample from which to determine default values.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpulquero%2FRotorHazard%2Fissues%2F46%23issuecomment-883269642&data=04%7C01%7C%7C049bbb2123264fc35c7d08d94b661fd0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637623724250958627%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BGQy7fZzctTbO9JA5DmBd2%2BfFkXz2PsR4%2FtaoOleSNw%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ2YA5SE7JNEOQ2VCJ2PNALTYVDEPANCNFSM5AVI5NZQ&data=04%7C01%7C%7C049bbb2123264fc35c7d08d94b661fd0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637623724250968583%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FG3E33D%2BVrpwpnPx4D0fSfiCXPXgIZ7dlYahKq6U%2FOY%3D&reserved=0.
RH defaults (as well as the retained settings from a previous RH setup) are too high for a PH to recognise lap passes.
Can the code identify if PH nodes are in use and adjust the LifeTime level accordingly?
It may require a flag-bit in the code which is cleared when a RH setup is discovered and set when a PH setup is recognised.
Going further, it would then be good to use that flag to alter the server options, removing or showing things that are only appropriate for RH and PH individually. I'm thinking of things like A) Marsahling B) EnterAt/ExitAt vs Lifetime
I recognise the extra work this would require, but PH isn't going to be acceptable if it's unnecessarily complicated for the user and not made as easy as possible in the user interface.