Open confused-Techie opened 1 year ago
I think the atom-ink package is likely on verge of being fixed.
And also, no-one likely installs atom-ink
themselves, it gets installed while installing uber-juno
package, so ...
Either way (be it fixed, or not), i think badging atom-ink
won't be a very good idea....
if anything, uber-juno package should get a badge meanwhile due to its error with Juno Error: Installing julia-client@0.12.6 failed
as shown in the image at https://github.com/pulsar-edit/pulsar/issues/482#issuecomment-1506577042
That error is posted in the issue-tracker upstream as well by lots of people, i'll try having a take at it as well, but, 30% it seems unlikely to be fixed to a decent stage
@goyalyashpal I appreciate you contributing on this issue, so we may want to add it to both then, in the unlikely event that someone installs atom-ink` directly.
But appreciate the insight, and do hope that it is properly fixed sometime soon, so we will absolutely keep an eye out for it being done.
But otherwise thanks a ton for your feedback, and I'll edit this when I have the time
@goyalyashpal has the maintainer actually committed to submitting it to Pulsar? Unless they do then we still have the issue of the "bad" version being in the backend and a badge will still need to be applied.
@goyalyashpal I appreciate the review, although we will still probably need to say both packages are broken.
Since uber-juno
is essentially a package that just installs other packages. Which one of those is atom-ink
. So there is no way to install uber-juno
without having atom-ink
begin to throw errors, which while uber-juno
itself isn't broken it is effectively broken, since there's no way to stop those errors from being thrown without major edits to the source code. Since until a newer version of atom-ink
is published to the Pulsar Package Registry, uber-juno
will still throw errors.
But since you've done a fantastic job up until now in getting these maintainers responsive to the issues at hand I'll reword this as recommended but may wait a bit before applying any badging to see if they are able to get newer versions submitted.
Thanks for keeping us up to date!
Unless they do then we still have the issue of the "bad" version being in the backend and a badge will still need to be applied.
yep, i have no problem with the bad badge on uber-juno, sorry if i suggested this as a change (though i think i haven't)... i just suggested these changes in wordings to bring them close to the reality (well, upto as far as i understood upto source level anyway :sweat_smile: - as i am pretty sure the packing and deployement part flows slightly over my head)
oh and also, one of the other changes i suggested was in parity with how it's done for other packages for which the update has not been packaged/pushed to pulsar --> the whole manual pulsar -p install ...
thing
Alright as it's been two weeks with no new version published by the maintainers of these packages, I'll go ahead and update this here.
Additionally, since the uber-juno
package will still install the broken version of the ink
package (even if ink has the fixes on the git repo), there's no command we can use to install both from the git repo, as uber-juno
will install what's available of ink on the registry.
So with all of that said, both packages are broken for better or worse, although we could include instructions on how to install ink
from the git repo only.
Appreciate all the effort @goyalyashpal has put into this one, sorry the maintainers haven't come through to get things updated.
there's no command we can use to install both from the git repo, as
uber-juno
will install what's available of ink on the registry.
this pretty much did not make sense to me back then. but now, after having a hands on experience with package management as a dev - this becomes perfectly clear.
wow on how well the concepts translate as following
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
[ ] Have you ran tests against this code?
[X] This PR contains zero code changes.
Description of the Change
This PR adds the badge addition to
atom-ink
to the admin actions log.Additionally adding the definition of a new badge type
Broken
.The need to add this badge was born from this discussion.