All new code requires tests to ensure against regressions.
However, if your PR contains zero code changes, feel free to select the checkmark below to indicate so.
[X] Have you ran tests against this code?
[ ] This PR contains zero code changes.
Description of the Change
This PR attempts to begin addressing the possibility of a misspelled repository key, or even missing key being present in the package.json of a remote package.
Which up until now would mean the package is unavailable for future version publications, unless manual action was made to fix it on the database itself.
This PR is simple, only protecting against a missing, or totally invalid repository field. It's still possible this contains a misspelling. While ideally this could protect against that as well, unfortunately there is no simple way to access the accurate repository during the publication process. Since we rely on GitHub redirects to support any renamed repos or users, while also relying on this to support repos that have transferred names. So by checking for exact spellings could cause this functionality to break. In which case a better solution will need to be found there, or an easy way for package authors to find support.
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
[X] Have you ran tests against this code?
[ ] This PR contains zero code changes.
Description of the Change
This PR attempts to begin addressing the possibility of a misspelled
repository
key, or even missing key being present in thepackage.json
of a remote package.Which up until now would mean the package is unavailable for future version publications, unless manual action was made to fix it on the database itself.
This PR is simple, only protecting against a missing, or totally invalid
repository
field. It's still possible this contains a misspelling. While ideally this could protect against that as well, unfortunately there is no simple way to access the accurate repository during the publication process. Since we rely on GitHub redirects to support any renamed repos or users, while also relying on this to support repos that have transferred names. So by checking for exact spellings could cause this functionality to break. In which case a better solution will need to be found there, or an easy way for package authors to find support.Resolves #169