Add TRACE Logging to Unpublish

pulsar-edit / package-backend

Pulsar Server Backend for Packages

https://api.pulsar-edit.dev

MIT License

12 stars 11 forks source link

Add TRACE Logging to Unpublish #195

Closed confused-Techie closed 1 year ago

confused-Techie commented 1 year ago

Requirements

Filling out the template is required.
All new code requires tests to ensure against regressions.
- However, if your PR contains zero code changes, feel free to select the checkmark below to indicate so.
[X] Have you ran tests against this code?
[ ] This PR contains zero code changes.

Description of the Change

It seems we are having additional issues during unpublishing of packages.

This PR adds additional logging to this section to gain insight into the issues being faced.

confused-Techie commented 1 year ago

The changes here were a team effort between @asiloisad and myself, to troubleshoot the second occurance of failure to properly unpublish community packages.

The full conversation is available on Discord. But otherwise we are now seeing successful unpublishing of community packages.

As the changes in this PR are already live, and all tests are passing, I'll go ahead and merge these changes, leaving in the extra TRACE logging within, since this section of the codebase still has much less logging than I'd like, the TRACE logging can be a nice stopgap if we encounter any further issues.