search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

src: Delete unused code in uninstall.js #104

Closed DeeDeeG closed 8 months ago

DeeDeeG commented 8 months ago

This is a quick follow-up to some code removal in PR 103.

In #103, after removing some code that does a ping to the backend (which we no-op/ignore anyway, on the backend side...) I didn't notice packageVersion is now defined but unused with those code removals.

Basically this is one line I missed in the cleanup. Things that were part of making the backend ping work. With that removed, this line/variable serve no purpose.

This basically finishes the cleanup started in #103.

(TL;DR: Another too-long writeup of a tiny diff. This is a one-liner removing a defined but unused var.)

EDIT: Whoops, mentioned and tagged the wrong PR. This PR follows-up on PR 103, not PR 95...

DeeDeeG commented 8 months ago

macOS CI failure is unrelated, it's the "old node-gyp, new Python" issues again.

I have to review how we worked around these things in CI for other repos. Wanted to get this PR out quickly, will have to come back around to fixing CI here soon.

confused-Techie commented 8 months ago

Taking a quick look here, so feel free to tell me if I'm wrong.

But I think the class utilized in this function getPackageVersion is also totally unused. So we should be able to delete line 30-36 as well.

Otherwise diff looks good and just like we would expect

DeeDeeG commented 8 months ago

Wow, you're right, getPackageVersion can go too! This file has to be almost half the length it was before, with all this pruning. [EDIT: Okay, not quite that proportion of code was removed, but a sizeable chunk. 34 lines pruned, whereas the file is now 79 lines long.]

confused-Techie commented 8 months ago

@DeeDeeG Thanks for taking a look and confirming what I saw there. More good news, now with that function removed, it looks like we can stop requiring season in this file as well!

DeeDeeG commented 8 months ago

With that removal, I'm reasonably confident-ish that there's no other dead/unused code that can simply be deleted from this file. Tempting fate with that, but I think this is good now(?).

DeeDeeG commented 8 months ago

No problem! Good to be thorough.

Thanks for the reviews/feedbacks.