search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

Implement Codacy Recommendations #113

Closed confused-Techie closed 8 months ago

confused-Techie commented 8 months ago

Alright, apologies to @DeeDeeG for the fact I just don't seem to stop making PPM PRs lol.

This PR should be the last one of the ones I've had semi ready to go, and implements the majority of the low hanging fruit flagged on codacy.

Thanks again to anyone able to review this one, and hopefully I'll calm down in this repo afterwards

DeeDeeG commented 8 months ago

I'm surprised how many unused require()s there are in this repo. Must have been a fair amount of churn throughout development.

DeeDeeG commented 8 months ago

Alright, apologies to @DeeDeeG for the fact I just don't seem to stop making PPM PRs lol.

Lol, no worries. I happen to be available to review these at the moment. Good to see some, er, winter cleaning around this repo, heh.

confused-Techie commented 8 months ago

Thanks for the review @DeeDeeG!

And yeah it's surprising how much junk is left over in this repo, so I'm more than happy to just delete it lol