With PPM now properly setup on Codacy, the next two biggest suggestions are the following:
No Unused Vars: For this one I've added a small bit of configuration to the eslint config file, to not apply this rule if the variable begins with an underscore, which should solve solve that issue by and large for us.
No Assignment in Operand: This issue is less invasive than it appears. While there are some instances where variables are assigned a value within an operand, other situations were found such as old CoffeeScript is not operators that weren't decaffed cleanly, and also a single instance of what appears to be a typo of = rather than ==
With this issues addressed, we don't expect to see any change in hope behavior ourselves.
With PPM now properly setup on Codacy, the next two biggest suggestions are the following:
is not
operators that weren't decaffed cleanly, and also a single instance of what appears to be a typo of=
rather than==
With this issues addressed, we don't expect to see any change in hope behavior ourselves.