Fix test failure due to missing atom command

pulsar-edit / ppm

Pulsar Package Manager

MIT License

35 stars 13 forks source link

Fix test failure due to missing atom command #124

Closed toddy15 closed 7 months ago

toddy15 commented 7 months ago

If pulsar is installed from the .deb package, the command ppm test fails with this error:

Error spawning atom: spawn atom ENOENT

Using pulsar instead of atom fixes this.

toddy15 commented 7 months ago

I did not update spec/test-spec.js, this is fixed now. Hopefully all tests should now pass.

DeeDeeG commented 7 months ago

EDIT: Oops, commented this on the wrong Pull Request.

DeeDeeG commented 7 months ago

CI is passing, thanks again! Merging now. 👍

EDIT to add: We need to do a PR to update core repo to use this updated version of ppm. It can be expected to be included in Pulsar regular 1.114 release, and possibly Rolling before that. Core team will generally handle this as time permits, but I wouldn't be against a PR to do so from any contributor, but nor is it expected.