search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

Rewrite publish logic #132

Closed confused-Techie closed 3 months ago

confused-Techie commented 3 months ago

After numerous issues and reports and pain points of this publish logic, we hit a point after enabling strict versioning on the backend to discover that the original logic completely fails now.

I'll try to update this with more details with more time, but for now, here's an attempt that should resolve our woes.

DeeDeeG commented 3 months ago

Posting this feedback from the Discord thread, in case it gets lost otherwise:

ppm publish --tag isn't working with this branch:

% ~/ppm/bin/ppm publish --tag v0.3.0
A version, tag, or new package name is required

Working on master branch:

% ~/ppm/bin/ppm publish --tag v0.3.0
Publishing deedeeg-my-package-10982367019823@v0.3.0 ✓

Sadly it's seeming like we might not have any unit tests for this?

DeeDeeG commented 3 months ago

Speaking of which, the Discord thread: https://discord.com/channels/992103415163396136/1241217301529886853

And the start of the recent round of discussion around this topic, preceding the formal Discord thread about it by a bit: https://discord.com/channels/992103415163396136/992109539346370661/1240836443299905606

confused-Techie commented 3 months ago

Thanks for the approval, gonna go ahead and merge this one for now, then we just gotta get it updated in pulsar sometime soon