search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

Update many dependencies #133

Closed DeeDeeG closed 3 weeks ago

DeeDeeG commented 3 months ago

These were some low-hanging fruit for upgradable dependencies.

(And some slightly higher-hanging fruit, TBH, see the custom resolutions in package.json)

Might as well, if we can, right?

Tests pass on my machine, and I can still install packages. (I tried language-carp and atom-ide-base; Both had no obvious issues installing, in terms of being able to run ppm install language-carp or ppm install atom-ide-base without running into any errors on the CLI, at least.)

Additional manual testing may be desirable, if we can get folks with the knowledge and time to thoroughly do so. Otherwise, we may just have to ask people to test it in the wild if we want to update these deps. In which case, best to have it in Rolling for a while and put out a call for testing there. Otherwise, we can perhaps try to call for testing of ppm itself with these changes before shipping it with Pulsar. But in any case, updating these seems like a good idea, IMO.

Note: For documentation of Yarn's "resolutions" system, see: https://classic.yarnpkg.com/en/docs/selective-version-resolutions

DeeDeeG commented 3 weeks ago

Gonna go ahead and merge this. Thanks for the review, even if it's a lite-approve I'm sure ppm will get testing to reveal if there are any problems before long. Besides that I used it for some things myself and it went okay.