search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

meta: Normalize package.json and lockfile line endings #54

Closed DeeDeeG closed 1 year ago

DeeDeeG commented 1 year ago

Prevents large, line-ending-only diffs when package metadata (mostly the dependencies) are updated on various OSes/platforms.

Especially Windows (CRLF) vs macOS/Linux (LF).

Why do this PR? (click to expand): _(This was a rare but very annoying issue that cropped up _very infrequently_ over at upstream (official Atom team) apm and at atom-community/apm repos.)_ _(It hasn't been a problem here so far, and maybe it was only an issue once upon a time, given that **I think** the `package-lock.json` was actually committed with **mixed line endings** within the one file at one point, if you can believe that???!?! So I don't expect it to happen here again, and yet having to commit a "normalize line endings" commit of the file itself is so annoying if it were to happen again, and creates so much noise in the `git blame`... etc. This just prevents that all from happening in the first place.)_
DeeDeeG commented 1 year ago

Thank you for the reviews @Meadowsys and @confused-Techie, and for the merge @confused-Techie!