search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

Decaffeinate spec helper (updated) #63

Closed 2colours closed 1 year ago

2colours commented 1 year ago

This is basically the updated version of https://github.com/pulsar-edit/ppm/pull/19, targeting the dedicated branch for decaffeinization. The only thing I changed on principle is the semicolons: I think we shouldn't go for the "automatic semicolon insertion" rules. Explicit is better than implicit with this surely.

If you think the coffee file shouldn't be removed, let me know and I will drop that commit.

confused-Techie commented 1 year ago

@2colours This looks fantastic!

Totally agree, automatic semi-colon insertion I feel like is messy and harder to read, so a fan of them being put back in.

I'm seeing you also got ride of the map to invoke andCallThrough(), not totally needed, but does make things a little less messy, and looks like it'd still do the exact same thing, so super rad!

And sure thing, removing the CoffeeScript at this point seems like a fine move to me, and with all that said

So if you wanna continue with this process by all means, and hope you can see what I mean by how much easier it is to review.