search

pulsar-edit / ppm

Pulsar Package Manager
MIT License
35 stars 13 forks source link

Decaffeinate ci spec #65

Closed 2colours closed 1 year ago

2colours commented 1 year ago

Supersedes https://github.com/pulsar-edit/ppm/pull/21.

unused occurrances of request changed to _request, and one rather shouldn't require JSON files so reading it synchronously.

confused-Techie commented 1 year ago

@2colours One question I have concerns about, since the decaf PRs will be merged to main, will it cause issues that they are all separate PRs? Since these changes would be totally fine to be all on one PR.

2colours commented 1 year ago

@confused-Techie I'm doing it like this for one simple reason: this is how @GuilleW left it behind. I can just checkout the branch, rebase it to the new one, play around with the differences that happened on main in the meantime... but you are right, probably the end result should be a decaf branch where everything is decaffeinated. Which is, I think, where these PR's will lead.