pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

CI: Fix workaround for Homebrew node in Cirrus on macOS #1002

Closed DeeDeeG closed 6 months ago

DeeDeeG commented 6 months ago

This workaround was necessary before because something broke.

Now the workaround is the thing that breaks things.

Go figure. [EDIT: workaround just needed to be tweaked to hit the right package name. Mostly still valid after all.]


Follow-up to https://github.com/pulsar-edit/pulsar/pull/961.

This one is a little more straight-forward than 961, thank goodness. Apparently, Homebrew's node cask is not preinstalled anymore in the latest CI base images we've been auto-updated to, so trying to remove it gives an error now.

Solution: Don't do that. 👍 (Remove node@20 cask instead!)

Verification Process

Ran this through Cirrus via a custom cron job. It worked. CI is passing for that run with the fix. 👍 https://cirrus-ci.com/task/5146025353019392

DeeDeeG commented 6 months ago

Thanks for the review. 👍