search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.24k stars 137 forks source link

Tree-sitter rolling fixes, 1.118 edition #1010

Closed savetheclocktower closed 3 months ago

savetheclocktower commented 4 months ago

More fixes for TypeScript/JavaScript, plus fixes in grammar-matching logic for PHP. More to come, no doubt.

Psychosynthesis commented 4 months ago

I wonder how to find out what has changed in the binary files? Or are they automatically generated from the rest?

I'm just starting to slowly understand the entire codebase, so I don't understand a lot.

savetheclocktower commented 4 months ago

I wonder how to find out what has changed in the binary files? Or are they automatically generated from the rest?

I'm just starting to slowly understand the entire codebase, so I don't understand a lot.

The WASM files are generated from their various Tree-sitter repos. This is partly why we introduced the parserSource convention in the grammar files — it tells you which commit SHA the WASM was built from.

Hence if you wanted to know what's changed in tree-sitter-php, you could compare b569a5f2c0d592e67430520d1a0e1f765d83ceb0 to 27afeb02e49ff30acd17b67897b1c0114561a38c. Not the easiest thing to do, but it's at least possible.

Psychosynthesis commented 4 months ago

@savetheclocktower thanx, got it.

savetheclocktower commented 3 months ago

I never put this PR into draft status, but if I had, I'd be taking it out of draft status right now. It's ready for review.