search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.24k stars 137 forks source link

Update ppm to commit 3542dee00f4622f7458f2f65f05e5 #1014

Closed DeeDeeG closed 3 months ago

DeeDeeG commented 4 months ago

Includes ppm Pull Requests:

Notes about notable changes:

PR 132 over at the ppm repo in particular is notable, as it fixes an issue with publishing a brand new package with the ppm publish patch command or similar. Other sub-commands of publish to get a brand new package pushed to the Pulsar Package Registry are somewhat more cumbersome or advanced, so this gets the main popular way of publishing a new package "back online," so to speak.

This seems to have also fixed ppm publish --rename, which may have been broken for some time in ppm's master branch? As per my most-recent testing. Seems odd if I didn't recall this being reported before, but that was my impression from researching and testing this fix.

Thanks for @confused-Techie for working through that fix, this has been a while in the making due to being a somewhat puzzling set of issues to debug and troubleshoot under the hood of ppm, also benefiting from knowledge of how the backend itself works.

(Giving myself some credit: I helped test the fixes extensively and gave feedback to develop the approach taken for the fix.)

Thank you also to multiple people for reporting this issue and bringing it to our attention. And, of course, apologies for the disruption to publishing your packages! The fix is here now.

(PR 127 is less notable for end-users, as express is a devDependency only, and would not be expected to be called in "production" or anywhere outside of running ppm's own tests.)

DeeDeeG commented 4 months ago

See-also: https://github.com/pulsar-edit/ppm/pull/133, which I just posted over at ppm repo.

Perhaps we want to get that shipped with Pulsar soon, if reviewers like that PR to begin with. Just calling it out, as we don't always update ppm in core repo that often (though we easily can). I figured anyone reviewing this PR might want that tidbit of info on their radar.

Best regards.