Application icon visual error on macOS

[Jesse-Cooper]

Thanks in advance for your bug report!

• [x] Have you reproduced issue in safe mode?
• [X] Have you used the debugging guide to try to resolve the issue?
• [X] Have you checked our FAQs to make sure your question isn't answered there?
• [X] Have you checked to make sure your issue does not already exist?
• [X] Have you checked you are on the latest release of Pulsar?

What happened?

I've seen that in a previous issue the icon was fixed to remove this visual error, however it still remains on macOS (intel) where I believe I've narrowed it down to this file. It is a 1028x1028 image which I believe all macOS applications use.

Here is how it looks on the computer:

Pulsar version

1.101.0-beta

Which OS does this happen on?

🍎 macOS

OS details

13.2 (22D49)

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

1. Install Pulsar
2. It is the application icon

Additional Information:

No response

[meadowsys]

Can confirm. I did bring this up in the discord server before, someone (can't remember who) said it was because the icon was cropped out of a larger image, and that it was only temporary until the artist provides the individual icons. Can't remember if it was supposed to be fixed, though

[Jesse-Cooper]

Note, there may be other icon files with the same visual issue. The file linked is the image I believe is causing this specific error.

[Daeraxa]

Yeah I thought this one had been solved but maybe that was just Linux icons. We still haven't decided if we want to use a single unified icon or if we want to make a macOS squircle one.

[meadowsys]

As a macos user I would be leaning towards the latter heheh >.> (no rush though, of course)

[Digitalone1]

The icon in the open post is the PNG icon that has an issue and it was showing the same way on Arch in the previous release (just because the AUR packager fixed the wrong path in the installation script, otherwise it was not shown as it happened on other distros).

Linux icons were fixed in the latest release, but I though you fixed also the icons for other platforms.

[Digitalone1]

This is the icon with the visual issue:

https://github.com/pulsar-edit/pulsar/blob/master/resources/app-icons/beta.png

Which at the moment is only used on mac.

https://github.com/pulsar-edit/pulsar/blob/master/script/electron-builder.js#L178

Windows uses the ico format and Linux has their own because of the special way electron-builder has to construct icon paths on Linux.

The only thing to do is to clean that PNG one. Maybe replacing with the following:

https://github.com/pulsar-edit/pulsar/blob/master/resources/pulsar.png

[mdibella-dev]

Based on the cleaned PNG file, I took the liberty of creating a customized app icon using the Apple Human Interface Guidelines (HIG) template file.

Attached is the ICNS file (zipped):

pulsar.icns.zip

[mdibella-dev]

Created a new file, based on the symbol graphic @confused-Techie provided.

beta.icns.zip

[SilentGlasses]

Nice work with the icons @mdibella-dev ..

Ps, if anyone wants to use it on their current install...

• Unzip the file
• Double-click the beta.icns to open it in Preview
• From the left sidebar, right-click on the one you want then select Export As
• Browse to Applications and locate the Pulsar app
• Right-click on the app and click Get Info
• Drag and drop the exported png file on the small Pulsar icon in the top left of the window .

[meadowsys]

Ps, if anyone wants to use it on their current install...

372's CI binaries also have the icon, is another option

[mdibella-dev]

Ps, if anyone wants to use it on their current install...

372's CI binaries also have the icon, is another option

Thanks for the hint. Looks great in my opinion.

[aphive]

Ps, if anyone wants to use it on their current install...

372's CI binaries also have the icon, is another option

True, not everyone knows how to use the binaries tho ... Lot's of n00bs still running around :)

[meadowsys]

Hrm, maybe I should adapt my downloader thingie (that I made for atom-community back when we were still active there) to Pulsar's infra. but this is getting a little off topic :p

[mdibella-dev]

In my opinion, the issue has been resolved with the merge and can thus be closed.

[meadowsys]

I think so too!