search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.26k stars 136 forks source link

Developer tools need `--no-sandbox` option on exec to be enabled in the AppImage version #397

Open machitgarha opened 1 year ago

machitgarha commented 1 year ago

Thanks in advance for your bug report!

Where is the URL that this occurs?

https://pulsar-edit.dev/docs/atom-archive/hacking-atom/#check-for-errors-in-the-developer-tools

What's your issue?

In order for someone to be able to enable developer tools, he needs to run Pulsar with --no-sandbox, as stated here.

As people should go there to play with the issue they encountered, they might not be able to enable developer tools, so this is unintuitive.

Which OS/Browser/Version does this happen on?

Not relevant

Steps to Reproduce/Additional Details:

No response

Spiker985 commented 1 year ago

--no-sandbox is included as a part of the pulsar.sh file on mac and linux

machitgarha commented 1 year ago

I see, but if I don't add the --no-sandbox option manually, the shortcut to open Developer Tools doesn't work (i.e. Ctrl+Shift+I).

P.S: I'm using the AppImage version of the Pulsar, although it shouldn't make a difference.

machitgarha commented 1 year ago

So, the problem is AppImage-specific. The AppRun file of the AppImage is not the same as pulsar.sh, and it doesn't call it too (i.e. located in resources/pulsar.sh).

Daeraxa commented 1 year ago

We do note this on the appimage download page:

[1] Appimage may require --no-sandbox as an argument to run correctly on some systems.

If you have a solution for it then we are all for it.

confused-Techie commented 1 year ago

So while we appreciate the bug report, like mentioned this is explicitly mentioned on our website for this one type of download. And as we don't have any known way to fix this (other than bumping Node thus Chromium, which this version of chromium is the actual reason for this issue) I'm inclined to say to close the issue as there's no other known way to fix this for AppImage.

It will be fixed, but it's otherwise a documented issue. But please if there is some other methodology to fix this we would all be happy to have it. Or otherwise if we feel it's a good idea to leave this open as a sort of documentation of the issue we could also do that as well. But otherwise I would hope to keep our issue count down.

Again thanks a ton for contributing!

machitgarha commented 1 year ago

Ah. @Daeraxa and @confused-Techie, I didn't pay enough attention. Sorry.

Because I have some experience with AppImages, maybe I can fix this. I'll look into it if I find time.

Thanks for your quick responses!

confused-Techie commented 1 year ago

Ah. @Daeraxa and @confused-Techie, I didn't pay enough attention. Sorry.

Because I have some experience with AppImages, maybe I can fix this. I'll look into it if I find time.

Thanks for your quick responses!

No sorry needed. But if you are able to that'd be amazing! Wishing you good luck with it, feel free to ask any questions here or on our Discord (May get a faster response there)