confused-Techie
commented
1 year ago Personally on this topic, I'd vote that the colour of the quotation marks and content of a key is the same colour, and of course different from the actual value.
As for what colour that's hard to say, but I'd think either we want to have it try and mimic the colouring we use for other syntax themes, such as the variable assigning colour, or we instead focus on making it look nice within the existing JSON file. In which case an off green would likely look the nicest, like VSCode does
Daeraxa
Have you checked for existing feature requests?
Summary
VSCode distinguishes the highlighting of JSON string keys from JSON string values.
The built-in themes in Pulsar don't seem to do this.
When this came up in Discord, there seemed to be some support for the idea of changing the built-in syntax themes to support this. The TM-style JSON grammar can already distinguish JSON keys by targeting the
meta.structure.key.jsonselector (though you'd need to style thestring.quoted.double.jsonselector inside of it). The modern-tree-sitter JSON grammar doesn't yet use themeta.structure.key.jsonscope name, but that enhancement is present in #555.What benefits does this feature provide?
At-a-glance distinguishing of keys from values can be useful for things like JSON config files.
Any alternatives?
Can't think of any alternatives. The crucial thing here is how to distinguish the key from the value — which color to use, and whether to use the same color for the quotation marks or to recolor only the content inside the string. I don't use a built-in syntax theme, so I'm happy to leave those decisions to someone who does.
Other examples:
No response