Remove "Show Tab Bar"/"Show All Tabs" menu items on macOS

[mjrodgers]

Have you checked for existing feature requests?

• [X] Completed

Summary

Running Pulsar on macOS, the View menu has two options at the top, Show Tab Bar and Show All Tabs. But these don't relate to the Pulsar tabs for files, they are for some kind of system-defined "app tabs" that aren't (to my knowledge?) implemented in Pulsar.

For example, if you Show Tab Bar it just gives an extra bar between the title bar and the actual tabs for open files.

Presumably the intended behaviour (by Apple) would be that you could have different tabs here that play the role of different windows; so each of these tabs would house their own project. But this is not implemented. We can see that if we Show All Tabs the current project for the window is displayed, and a greyed-out option for adding a new "tab".

It seems like these options should be removed from the View menu on macOS.

What benefits does this feature provide?

Reduces menu clutter, also avoids having confusing menu items that don't provide any functionality.

Any alternatives?

I guess an alternative would be to implement these features, and let these system "tabs" each hold their own Project. Then you could have your open Pulsar projects all in one application window instead of having a separate window for each (if you wanted to do this).

Other examples:

No response

[confused-Techie]

Thanks a ton for reporting this one!

@mjrodgers So I took a quick look at this, admittedly I don't have a macOS machine to access, but I just want to confirm that you've launched Pulsar in Safe Mode?

I can't find any option being added to the menu bar from either core or the tabs package that adds this specific option.

Which makes me believe it may be caused by a community package. Although, admittedly there have been a few issues logged to Atom previously where users had trouble with this option disappearing, and updates to Atom seemed to always be the solution, without much if any explanation.

So this very well might be a built in feature that we can remove, I just can't seem to find where in the repo it actually exists. So if anyone has any insight that'd be awesome

[mjrodgers]

Yes, it is absolutely still there in safe mode.

I think actually it appears on macOS by default unless it's explicitly disabled.

Here is some info about the issue: https://github.com/electron/electron/pull/7415 Hide Show Tab Bar menu item on macOS Sierra by kevinsawicki · Pull Request #7415 · electron/electron github.com

On Jul 18, 2023, at 5:08 PM, confused_techie @.***> wrote:

Thanks a ton for reporting this one!

@mjrodgers https://github.com/mjrodgers So I took a quick look at this, admittedly I don't have a macOS machine to access, but I just want to confirm that you've launched Pulsar in Safe Mode?

I can't find any option being added to the menu bar from either core https://github.com/pulsar-edit/pulsar/blob/master/menus/darwin.cson#L130 or the tabs package https://github.com/pulsar-edit/pulsar/blob/master/packages/tabs/menus/tabs.cson that adds this specific option.

Which makes me believe it may be caused by a community package. Although, admittedly there have been a few issues logged to Atom previously where users had trouble with this option disappearing, and updates to Atom seemed to always be the solution, without much if any explanation.

So this very well might be a built in feature that we can remove, I just can't seem to find where in the repo it actually exists. So if anyone has any insight that'd be awesome

— Reply to this email directly, view it on GitHub https://github.com/pulsar-edit/pulsar/issues/647#issuecomment-1640409505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWIWKA7Z4VYO6DZZ23F2LXQ2RHBANCNFSM6AAAAAA2ODTDXE. You are receiving this because you were mentioned.

[savetheclocktower]

Yeah, this looks like an Electron thing.

What's odd is that the PR @mjrodgers linked is supposed to have fixed this years ago, but we're seeing this on Electron 12.

[mjrodgers]

Yeah, definitely interesting. Not sure if it's a regression though (the issue is also on Atom 1.60.0 running Electron 9).

On Jul 18, 2023, at 11:16 PM, Andrew Dupont @.***> wrote:

Yeah, this looks like an Electron thing https://stackoverflow.com/questions/73408994/electron-automatically-adds-hide-tab-bar-and-show-all-tabs-to-view-menu-on.

What's odd is that the PR @mjrodgers https://github.com/mjrodgers linked is supposed to have fixed this years ago, but we're seeing this on Electron 12.

— Reply to this email directly, view it on GitHub https://github.com/pulsar-edit/pulsar/issues/647#issuecomment-1641003255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWIWLDHBXAM7Z5VJ4DU3DXQ34MRANCNFSM6AAAAAA2ODTDXE. You are receiving this because you were mentioned.