pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.34k stars 141 forks source link

decorateMarker() causes whole UI to break, same code used to work in Atom #731

Open sadaszewski opened 1 year ago

sadaszewski commented 1 year ago

Thanks in advance for your bug report!

What happened?

When my plugin calls decorateMarker() in my custom gutter to set the following style for my marker { width: 46px; } the whole UI breaks, with the horizontal scrollbar moving up about 20% of the window height towards the middle of the text editor (and floats over the text), the text editor is shifted a few lines up (uppermost part out of the viewport, so e.g. first line or two are completely inaccessible) - so everything is mangled and unusable.

Pulsar version

1.109.0

Which OS does this happen on?

🪟 Windows

OS details

Windows 10

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

Add custom gutter Add a marker with some text in it (e.g. "AB") Decorate the marker with { width: 46px; }

Additional Information:

No response

Daeraxa commented 1 year ago

What version of Atom was this last working in?

savetheclocktower commented 1 year ago

Also, an actual code block that demonstrates this issue would be ideal. That way we could paste it into the dev console or drop it into an init.js file to reproduce the issue as quickly as possible.

sadaszewski commented 1 year ago

Many thanks for the feedback. Last Atom version that I used was 1.51.0 x64. I will try to prepare an isolated code block to reproduce in Pulsar.