URL after a multibyte colon no longer recognized on GitHub Markdown grammar - Githubissues

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor

https://pulsar-edit.dev

Other

3.33k stars 140 forks source link

URL after a multibyte colon no longer recognized on GitHub Markdown grammar #885

Closed luixxiul closed 10 months ago

luixxiul commented 10 months ago

Thanks in advance for your bug report!

[X] Have you reproduced issue in safe mode?
[X] Have you used the debugging guide to try to resolve the issue?
[X] Have you checked our FAQs to make sure your question isn't answered there?
[X] Have you checked to make sure your issue does not already exist?
[X] Have you checked you are on the latest release of Pulsar?

What happened?

On 1.113.0 URL after a multibyte colon is no longer recognized on GitHub Markdown grammar.

Screenshot from 2024-01-20 14-02-20

The issue is not reproduced on 1.109.0.

Screenshot_2024-01-20_05-05-37

Pulsar version

1.113.0

Which OS does this happen on?

🐧 Debian based (Linux Mint, Ubuntu, etc.)

OS details

Ubuntu

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

Install 1.113.0
Enable "GitHub Markdown" grammar
Paste 北宋行政区划：https://web.archive.org/web/20231221225348/https://blog.beeper.com

Additional Information:

No response

savetheclocktower commented 10 months ago

tree-sitter-markdown is definitely supposed to detect all of these. But I can fix this one with a hyperlink injection for the ones it misses.

Thanks for the report! I'll be closing this in favor of #878, but please keep track of that issue to learn when this is fixed.