search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

[meta] Update Cirrus `GITHUB_TOKEN` #924

Closed confused-Techie closed 9 months ago

confused-Techie commented 9 months ago

This PR updates the GITHUB_TOKEN for CirrusCI. As the previously used token had expired yesterday.

Getting this updated will be a requirement for our next Regular Release

meadowsys commented 9 months ago

The only way we'd know if this is not working

now I wonder if the GitHub API just silently proceeds unauthenticated (if it can) on invalid token, or hard errors (I would think its the latter, but I'm not sure, thinking about it)

confused-Techie commented 9 months ago

@Meadowsys From my experience GitHub will error out on an invalid token. Since at that point it becomes an authentication failure, rather than a missing parameter it will try to skip. So pretty sure if we incorrectly set this value we would see lots of failures on the next CirrusCI run due to authentication failures in GitHub.

But thanks both of your for your review!

meadowsys commented 9 months ago

GitHub will error out on an invalid token

then it would be pretty obvious if it doesn't work, will just error out immediately >w<