pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

deps: Update github to v0.36.20-pretranspiled to bump dugite #925

Closed DeeDeeG closed 9 months ago

DeeDeeG commented 9 months ago

Includes github PR:

(Which I excluded at the last moment from the previous github package version, v0.36.19[-pretranspiled].) ... Effectively bumps dugite from 2.1.0 to 2.5.2. Should improve github package's compatibility with ARM Linux?

Description of the Change

Update github to v0.36.20-pretranspiled to bump dugite.

Effectively bumps dugite from 2.1.0 to 2.5.2. Should improve github package's compatibility with ARM Linux?

Alternate Designs

Don't bump dugite?

Possible Drawbacks

Not super widely tested, but with some brief testing, this didn't surface any issues last time a couple of people looked at it (myself and Dae at least).

Verification Process

I tested this bump not breaking anything on my x86-64 machine some weeks ago, and at that time I believe @Daeraxa was also able to confirm it made the github package less broken on ARM Linux at that time.

EDIT: Tested this some more just now on macOS, with this PR's binary, looking good to me.

Release Notes

Update github package to v0.36.20-pretranspiled, to bump dugite dependency to 2.5.2 -- should improve github package's compatibility with ARM Linux

DeeDeeG commented 9 months ago

Did a bunch of stuff in the git and github panes, everything I tried appears to work.

DeeDeeG commented 9 months ago

Thank you for the approve, and with some further last minute testing, I think we are good to go merging this for 1.114 today.

Merging now!