pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

[symbols-view] Remap go-to-declaration commands on Windows/Linux #926

Closed savetheclocktower closed 9 months ago

savetheclocktower commented 9 months ago

This is a quick one. @Spiker985 discovered that the Symbols View: Go To Declaration and Symbols View: Return From Declaration commands used key shortcuts that shadowed the built-in Editor: Add Selection Above and Editor: Add Selection Below commands on Windows and Linux.

The symbols-view commands didn't even have mapped keys on Windows until 1.113. (If I had to guess, I'd guess that ctags didn't work on Windows at some point?) But these commands have always conflicted with one another on Linux!

To fix this, I'm adding a modifier key to the default key combinations on these two platforms. These new key combinations don't conflict with anything in the core keymaps folder, nor any other keymaps I can find in the pulsar project.

DeeDeeG commented 9 months ago

Merging now, thanks!