pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

Publish GitHub Repository Dropdown Showing Overflowing Profile Icon #952

Open D-Maxwell opened 8 months ago

D-Maxwell commented 8 months ago

Thanks in advance for your bug report!

What happened?

image

I think the above speaks for itself.

Pulsar version

1.114.0

Which OS does this happen on?

🪟 Windows

OS details

10 Pro 22H2

Which CPU architecture are you running this on?

None

What steps are needed to reproduce this?

In GitHub panel, click Publish & Initialise Repository. Be greeted with a blinding, white filled dropdown, due to your user's profile icon spanning its whole width.

Additional Information:

This seems like an easy issue to fix, as all it took to get it back to a seemingly normal state --non-jarring, at the very least-- was to explicitly tell two elements to size themselves according to the dimensions of their direct parent, as shown here : image image

The following rules were used to quickly "fix" this :

.Select-placeholder, .Select--single > .Select-control .Select-value {
    padding: unset;
}
.github-RepositoryHome-ownerOption {
    height: 100%;
}
.github-RepositoryHome-ownerAvatar {
    height: 100%;
    /*padding: 0.2em;*/
}
confused-Techie commented 8 months ago

Thanks a ton for reporting this, and especially for including a fix, seems pretty straightforward to implement!

pbanana commented 5 months ago

I'm having the same issue with 1.117, installed using flatpak on Tumbleweed.

D-Maxwell commented 5 months ago

Thanks a ton for reporting this, and especially for including a fix, seems pretty straightforward to implement!

Any ETA on merging this ?