search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.33k stars 140 forks source link

Debugging when a package service is incorrect #995

Closed mauricioszabo closed 6 months ago

mauricioszabo commented 6 months ago

This PR is basically to add some debugging info for providers and consumers. Currently, when a package registers as a service provider or a service consumer, and doesn't actually implements the right interface (a function, basically) the package loader silently ignores it. This commit adds a warning to console so that we know a package did the wrong thing.

DeeDeeG commented 6 months ago

The CI failure is probably unrelated, see https://github.com/pulsar-edit/pulsar/pull/996 hopefully for the fix.

EDIT: Oof, never mind, #996 still needs some work. But hopefully a fix will be available soon, and yeah looks like this it's not this PR's fault for CI failing. EDIT 2: See https://github.com/pulsar-edit/pulsar/pull/997 instead for a CI fix.

DeeDeeG commented 6 months ago

Should I merge in the macOS CI fix to this branch and re-run CI to see if it passes? Or just go ahead and merge this one as-is? I think it's very nearly impossible for this to cause errors unless it so happens to try and access a var or property that's not defined. Then again, I doubt that this code path is exercised in our existing specs either.

confused-Techie commented 6 months ago

@DeeDeeG There's no harm in doing so, but I don't think it's needed. With both our approvals I think we are good to merge