search

pulsarim / pulsar-issues

0 stars 0 forks source link

Whatsapp: one contact has name BM even though they're listed in my phone as Brandon #22

Open ericmigi opened 5 years ago

ericmigi commented 5 years ago

Contact name is 'Brandon' number: +13054345151 but room got created as BM (WA)

Screen Shot 2019-05-16 at 11 06 20 AM
tulir commented 5 years ago

This is mostly intentional: it always uses the name the user set for themselves. It's already possible to configure the bridge to use the contact list name, but that doesn't really work for multi-user instances.

It would be possible to make it use the contact list name in the direct chat while keeping the user-set name in group chats. Should that be an option in the bridge?

ericmigi commented 5 years ago

Personally I think correct functionality should be to mirror what the bridge user experiences in their regular WhatsApp use so that switching to bridge is seamless from their perspective. Eg if they have a name for the user in their contact list, use that, if not use the name provided by user set name in group chats

tulir commented 5 years ago

The only way to display contact list names in group chats would be having separate puppet users and portal rooms on the Matrix side for each Matrix user who is using the bridge (rather than sharing portal rooms if two Matrix users are in the same WhatsApp group).

ericmigi commented 5 years ago

Got it. makes sense. What about just for 1-on-1 chats?

tulir commented 5 years ago

That's doable with per-room displaynames since the private chat portals are of course per-user.

ericmigi commented 5 years ago

cool, let's constrain this bug to just private chats.