pulse-browser / gluon

Build firefox forks with ease
https://docs.gluon.dev/
Mozilla Public License 2.0
73 stars 7 forks source link

Does not appear to be working on Windows 11 #17

Closed splatboydev closed 2 years ago

splatboydev commented 2 years ago

Possible Windows issue

I have installed the required dependencies and followed all the instructions, but it does not work.

image image image image (latest mozillabuild version) image

yarn version: image

image

choco version: image

All steps go fine until gluon download, where this error happens: image

I have tried resetting the folder and re-configuring the gluon project but it doesn't seem to affect anything.

PressJump commented 2 years ago

The directory you have the browser in which is "Frenon Browser," it appears that it contains a space. Tar does not like spaces between directory names and will detect it as a parameter in the cli. This applies to other parts of the browser as well. I believe removing the space will fix your problem with tar not being able to find your directory due to the space.

Example Below (Using Space): image

Closing the issue for now.

splatboydev commented 2 years ago

Originally, I was using C:\Users\<>\OneDrive\Documents\GitHub\freon, so this is true but the same problem happened either way. I moved it to a different folder but I'll try to re-run it now in case it works.

splatboydev commented 2 years ago

It looks like it's working now, so this was an error on my part. Sorry about that and thanks for the help

PressJump commented 2 years ago

No problem at all. Windows builds for the tool are very experimental so if you have any problems feel free to always create an issue. The reason I believed it was a directory issue was due to your terminal output which can be seen below. image

splatboydev commented 2 years ago

Is it therefore possible to use something like tar <args> "C:\etc etc\etc (dir with spaces)" <other args> in the tool?

PressJump commented 2 years ago

Yes, in theory. Attempting it with the git bash version of tar on Windows (what gluon uses for Windows) by enclosing the directory in double quotes yields the same error. There is undoubtedly a solution, but this is not the only part of the tool that requires no-spaces in the directory. If my memory serves me correctly, this also becomes an issue with browser symlinks so one way or the other, it will fail. For large code-bases, it is best practice not to use a directory with spaces due to this kind of problem.