search

pulse-browser / gluon

Build firefox forks with ease
https://docs.gluon.dev/
Mozilla Public License 2.0
69 stars 8 forks source link

Gluon package fails with Python >=3 #34

Closed splatboydev closed 1 year ago

splatboydev commented 1 year ago

Tested on Windows 11 latest, on MozillaBuild latest. This is fixed if you change the code in base.py to next(). image

trickypr commented 1 year ago

This is an upstream error with mach, where malformed -j# args will cause mach to crash. If you are using the make -j command, ensure that the number is directly after the "j". For example, -j4 works, but -j 4 will crash.

As a side note, you should avoid specifying how many threads your build uses unless mach crashes for some reason. Mach will already try and push the most out of your system (e.g. if you have 16 threads, mach will run on all 16 threads, given you have 1GB of ram per thread). The only reason to use -j or similar is if you are running into OOM crashes or your system miss-reporting core count.

splatboydev commented 1 year ago

I don't use -j, actually. I generally just change the MOZ_PARALLEL_BUILD variable but that seems to be a shorthand for specifying -j.