Closed peshi closed 12 years ago
don't open that commit in your browser ;)
@peshis how do you fetch it manually? using the github zip link?
I am using the update site normally, but when I noticed that vendors are being installed on a no vendor project I went to the github zip link and discovered that I can't extract the files due to the above.
If I open the archive it seems that vendors are included in the novendor directory.
The update fixed the issue above, I'll close the issue.
As for unpacking the archive with paths more then 260 chars it seems to be an issue with winrar, it unpacks if I choose "Extract here" but not if I open the file and drag-drop.
Thanks!
@peshis the .zip won't help you anyway, it's just the java sources. thanks for pointing out the no-vendors bug.
@pulse00 What do you think about having the symfony version packed in a zip/tar instead of having it directly in the filesystem ?
I also faced a similar problem when I started to work on the annotation parser. I'm usued to put my projects in E:\work\Github
. So when I initially start to work on this project, I put it in E:\work\Github\Symfony2-Plugin\Symfony-2-Eclipse-Plugin
. But this was causing problems due to paths being too long on Windows.
I had to put it in C:\dev\Symfony-2-Eclipse-Plugin
instead to be able to clone the repository correctly.
Having a zip file for symfony would solve the problem I encountered and would reduce the number of changes in the github repository at the same time. I didn't look at all the code, but the biggest change would be to extract the archive when creating a new project within the plugin.
Tell me what you think about this, if you agree, I could propably send a PR for this change.
Cheers, Matt
@maoueh i think that's a good idea. The change would be actually really small. As you said, all it would require is unzipping it first. The related code is in the UI plugins` WizardPage
@maoueh ultimately, i think an automated update of the standard-edition would be the best scenario. currently every new symfony release requires a new build of the eclipse plugin. i've noted this in #73. maybe composer can be used to detect updates...
Ok, since we agree, I will work on a PR later this week. For now, I'm tweaking a bit the annotation parser, I'll send a PR for this soon.
For the automatic update, I saw the issue a week ago. I'm not totally sure how to handle the problem correctly. I thought at first of doing a simple crawler that would extract available versions directly from the symfony download page (http://symfony.com/download). Then, we could propose to download the new version of stick with the version bundled with the plugin.
Composer could help in a near future since it will be used by Symfony 2.1 when it will be out. We could probably take advantage of this great tool :)
It does not seem to work to create a project with no vendors, when selected it installs the package with vendors.
Also in a Windows environment when I fetch the plugin manually I try to unzip it to C:\ I receive the following errors.. "Total path and file name length must not exceed 260 characters".
It seem to fail here:
folder\com.dubture.symfony.core\Resources\vendor\symfony2\novendors\2.0.11\vendor\bundles... etc etc.
Cheers.